feat(python): Enable zstd compression by default #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angus-langchain
force-pushed
the
angus/enable-compression
branch
from
3300712 to
ec73127
Compare
angus-langchain
changed the title
agola11
reviewed
Jan 8, 2025
| threading.Thread( | ||
| target=tracing_control_thread_func_compress_parallel, | ||
| args=(weakref.ref(client),), | ||
| ).start() |
There was a problem hiding this comment.
we should return after here right? Otherwise we would hit the main loop for this thread, which we don't need if we're using the run compression strategy
There was a problem hiding this comment.
I think the thread needs to stay active at least until we can drain all the jobs from the tracing queue before we switch to compression. Thinking about the best way to do this
hinthornw
reviewed
Jan 10, 2025
agola11
reviewed
Jan 12, 2025
|
|
||
|
|
||
| @patch("langsmith.client.requests.Session") | ||
| def test_create_run_with_zstd_compression(mock_session_cls: mock.Mock) -> None: |
There was a problem hiding this comment.
would also add a test to ensure that the case where the info endpoint does not support zstd_compression_enabled uses regular multipart
There was a problem hiding this comment.
Additoinally, need a test case for DISABLE_RUN_COMPRESSION
agola11
approved these changes
Jan 13, 2025
agola11
reviewed
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.